fix(pages): make install-channel command box scrollable - #912
Conversation
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
lizhengfeng101
left a comment
There was a problem hiding this comment.
LGTM! Clean fix for a real UX annoyance — nice work.
A couple of ideas for a follow-up PR if you're interested:
-
Consider using
<div>instead of<span>—overflow-x: autotechnically only works on block-level elements. It works here because the span is a direct flex child, but it's a bit fragile. If someone later wraps it or changes the parent layout, scrolling could silently break. Swapping to a<div>(or adding explicitdisplay: block) would make the intent clearer. -
Scroll hint with a right-edge gradient — Now that the ellipsis is gone, there's no visual cue that the command extends beyond the visible area (especially on macOS where the scrollbar auto-hides). A subtle fade using something like
mask-image: linear-gradient(to right, black 90%, transparent)that disappears once scrolled to the end could help discoverability.
Neither of these is blocking — merging as-is. Thanks for the contribution!
Description
Type of Change
How Has This Been Tested?
make testpasses locallynpm run lint& npm commandsHere is the final effect:
Screen.Recording.2026-08-14.at.9.44.05.PM.mp4
Checklist
go fmt,go vet)Related Issues
none yet